Fix AnimatedImage aspectRatio issue when ratio is nil #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
reviewed
Mar 9, 2024
| @@ -631,6 +636,7 @@ extension AnimatedImage { | |||
| /// fill the parent context. | |||
| /// - Returns: A view that constrains this view's dimensions to | |||
| /// `aspectRatio`, using `contentMode` as its scaling algorithm. | |||
| @ViewBuilder | |||
There was a problem hiding this comment.
This does not need ? Seems I can not get what cause this.
Oh, I understand. You change this function to a ViewBuilder with if-else condition and return different View type for (some View), so this is needed
|
I just merge and code garden your changes Since you do not gain the edit access from your fork repo for this PR (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork), you'd better click that Actually, only 3 lines changes is enough. No need for temp func. |
dreampiggy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by hstdt on #279 removing
_AspectRatioLayoutmodifier whenaspectRatiois nil fixes the issue