Remove the WebImage placeholder maxWidth/maxHeight modifier, this may break some use case like TabView. If user want to use placeholder, limit themselves
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 75.00% 74.79% -0.21%
==========================================
Files 11 11
Lines 960 968 +8
==========================================
+ Hits 720 724 +4
- Misses 240 244 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… break some use case like `TabView`. If user want to use placeholder, limit themselves Also, polish the player API
dreampiggy
force-pushed
the
remove_placeholder_maxWidth_limit
branch
from
97d862c to
d17d44e
Compare
dreampiggy
force-pushed
the
remove_placeholder_maxWidth_limit
branch
from
2b510dc to
2935e2b
Compare
dreampiggy
changed the title
TabView. If user want to use placeholder, limit themselvesTabView. If user want to use placeholder, limit themselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This close #133
Use
.frame(maxWidth: .infinity)will cause theTabViewcrash. Actually I think this is SwiftUI issue.But anyway, we don't limit the placeholder frame, if you want, limit yourself using
.placeholder { MyView().frame(width: 100) }