Skip to content
This repository was archived by the owner on Aug 3, 2022. It is now read-only.

Add SPM support #10

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Add SPM support #10

merged 3 commits into from
Dec 17, 2021

Conversation

DwayneCoussement
Copy link
Contributor

This PR adds basic SPM support.
Can be tested by integrating the master branch of the forked repo. One should be able to remove a cocoapod and use the Swift Package instead without any further code changes.

@DwayneCoussement
Copy link
Contributor Author

@dreampiggy, could you review this one pls? 🙏

@dreampiggy
Copy link
Contributor

Hi.
Recently I'm busying in daily work and may have no enough time for open-source project. I'll have a check for small changes PR soon.
For large refactory or features, please try to summerize the idea and core changes, and I may check back in weekend.

@dreampiggy
Copy link
Contributor

dreampiggy commented Dec 15, 2021

This one seems need a little changes, please have a check like the one https://github.com/SDWebImage/SDWebImagePhotosPlugin/blob/master/SDWebImagePhotosPlugin/Classes/SDWebImagePhotosDefine.h

For example:

  1. The @import code should use the #if __has_include <XXX/XXX.h> #import <XXX/XXX.h> #else @import XXX compatibility hack. Because this repo need to support CocoaPods user who don't use module.

@DwayneCoussement
Copy link
Contributor Author

Thank you for the review; I've changed the imports and tested both against cocoapods and spm.

The only thing really added besides the imports is a Package.swift (and an autogenerated Package.resolved file).

@dreampiggy
Copy link
Contributor

Does SVGKit supports watchOS ? The package.swift list the watchOS_v2 ...

The podspec and Xcode seems does not add watchOS target. I remember the time when I create this repo, SVGKit does not have any watchOS.

@DwayneCoussement
Copy link
Contributor Author

Correct, I've updated the minimum platform requirements to align with SVGKit, great catch 👍

@dreampiggy
Copy link
Contributor

LGTM now.

@dreampiggy dreampiggy merged commit 9340cfb into SDWebImage:master Dec 17, 2021
@dreampiggy dreampiggy added the swiftpm SwiftPM related label Dec 17, 2021
@dreampiggy
Copy link
Contributor

Released v1.4.0

@DwayneCoussement
Copy link
Contributor Author

Thank you 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
swiftpm SwiftPM related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants