Use the CocoaPods libx265/libde265 dependency, instead of vendored static library #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the solution to fix SDWebImage/SDWebImageBPGCoder#4.
Using vendored static library, is a idea for simple C/C++ static library which does not have Xcode project or iOS cross-compiler support. However, it make it impossible to manage the version dependency.
For example, when two Pod use the same vendored library for
libx265.a
,libde265.a
, it cause unavoidable conflict. The solution, it's to introduce a common shared dependency. Since we already make the dependency available on CocoaPods:So, it's time to remove the vendored library and use the CocoaPods's one instead.