Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tvOS && watchOS && Carthage dynamic framework #2

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

dreampiggy
Copy link
Collaborator

@dreampiggy dreampiggy commented Jan 29, 2019

Features

  1. Add tvOS && watchOS platform support. Using the built libbpg static library
  2. Update Carthage project, which use libbpg-Xcode and build libbpg as dynamic framework.

Note: The important of using dynamic framework in Carthage project, is that it's not always a good idea, to link a static library inside your dynamic framework. Which cause duplicated symbol when other dependency have linked it as well. However, when using static library, this step can be shipped during ld linking and been avoid.

@dreampiggy dreampiggy merged commit 89a94b6 into master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant