Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for empty string path when building the DatabaseRequest #19

Closed
SD10 opened this issue May 5, 2017 · 0 comments
Closed

Add check for empty string path when building the DatabaseRequest #19

SD10 opened this issue May 5, 2017 · 0 comments
Labels
enhancement

Comments

@SD10
Copy link
Owner

SD10 commented May 5, 2017

Reasoning:

Currently, you can't use an empty String for the path property of DatabaseTarget in order to default to using the baseReference. This can be easily be fixed by adding a check for an empty string and only calling child(path:) on the baseReference if the String is not empty.
SD10 added a commit that referenced this issue May 13, 2017
@SD10
Use baseReference when String path is empty #19
b401313
@SD10 SD10 mentioned this issue May 13, 2017
Merged
SD10 added a commit that referenced this issue May 13, 2017
@SD10
Merge pull request #20 from SD10/bugfix/empty-path
d1be666 
Use baseReference when String path is empty #19
@SD10 SD10 closed this as completed May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SD10