Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Exit(), GetLaunchDir() and SConscriptChdir() static #4234

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

abitrolly
Copy link
Contributor

Continuation of #4224 which is a consequence of #4223

  • Do not initialize DefaultEnvironment when calling EnsureSConsVersion(),
    EnsurePythonVersion(), Exit(), GetLaunchDir() and SConscriptChdir().
  • Remove unused private method SConsEnvironment._exceeds_version().

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt (and read the README.rst)
  • I have updated the appropriate documentation

@bdbaddog
Copy link
Contributor

Doing this would require a deprecation cycle.

@abitrolly
Copy link
Contributor Author

For the private method that is not supposed to be exposed?

@bdbaddog
Copy link
Contributor

For the private method that is not supposed to be exposed?

Removing those methods from Environment()..

@abitrolly
Copy link
Contributor Author

This PR doesn't remove them. Should it start the deprecation cycle now that the docs moved methods into global scope?

@bdbaddog
Copy link
Contributor

You are correct. My mistake.

@bdbaddog bdbaddog merged commit e812848 into SCons:master Sep 15, 2022
@abitrolly abitrolly deleted the static-methods branch September 15, 2022 21:26
@mwichmann mwichmann added the maintenance Tasks to maintain internal SCons code/tools label Oct 21, 2022
@mwichmann mwichmann added this to the NextRelease milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks to maintain internal SCons code/tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants