Change appendenvpath default

[dmoody256]

Potential solution for #3276

Change the default to not touch the path.

Contributor Checklist:

• I have created a new test or updated the unit tests to cover the new/changed functionality.
• I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
• I have updated the appropriate documentation

[mwichmann]

Looks like there's a test that depends on the old default behavior.

[dmoody256]

I checked the related documentation in the man page, and it looks like its correct already, so that means the code before this PR was not in line with the documentation.

[bdbaddog]

I thought the docs didn't specify the default for delete_.. parameter?

…

On Thu, Jan 31, 2019 at 1:44 PM Daniel Moody ***@***.***> wrote: I checked the related documentation in the man page, and it looks like its correct already, so that means the code before this PR was not in line with the documentation. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3281 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFBNCrBeIsO2Da0I46a7VnQJ2-jfuTIks5vIzmJgaJpZM4aVHBC> .

[dmoody256]

I thought the docs didn't specify the default for delete_.. parameter?

They don't say an explicit default value, but they do describe the default behavior as:

This will only add any particular path once (leaving the last one it encounters and ignoring the rest, to preserve path order)

[bdbaddog]

So this is ready to merge right?
mingw failure expected at this point?

[dmoody256]

Yeah, this ones good to go

…

On Fri, Feb 1, 2019, 5:13 PM William Deegan ***@***.*** wrote: So this is ready to merge right? mingw failure expected at this point? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3281 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF2YzAdBMaAYP5CR1t9byLMKASqobMhLks5vJMoRgaJpZM4aVHBC> .