-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override build date with SOURCE_DATE_EPOCH #3221
Conversation
Please update CHANGES.txt So if SOURCE_DATE_EPOCH is not set, this is still changing the default format of the time/datestamp in the distibuted code right? |
Also, am I understanding the motivation correctly. |
The results should be bit-identical, so you can just compare the hash/digest of the resulting packages. We are nearly there (e.g. it is working for 95% of 11000 openSUSE packages already) Yes, it would change the date format. If there are many parsers around, we could leave the SConstruct version as is, but I guess, few people care about the man-page header. |
o.k. I'm going to leave this up for a few days and float the PR to our users mailing list. |
The man-page format is also particularly hard to understand (without looking at the source) - e.g. is 01/02/2018 January or February? Will add a |
US date formatting so January. |
In Germany, 01.02.2018 is the first of February and I don't want to know how many other variants exist around the world. |
Indeed. One of many locale based date/time/etc variations. |
src/CHANGES.txt
Outdated
@@ -162,6 +162,10 @@ RELEASE 3.1.0.alpha.yyyymmdd - NEW DATE WILL BE INSERTED HERE | |||
Three uses of variables not defined are changed. | |||
- Some script changes in trying to find scons engine | |||
|
|||
From Bernhard M. Wiedemann: | |||
- Allow to override build date with SOURCE_DATE_EPOCH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note that this is only about building SCons packages and not universal to builds done by scons when building other software.
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Also consistently use ISO 8601 date format to be understood everywhere. Also use gmtime to be independent of timezone.
master/src/CHANGES.txt
directory (and read theREADME.txt
in that directory)Allow to override build date with
SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
Also consistently use ISO 8601 date format
to be understood everywhere.
Also use gmtime to be independent of timezone.