create a class for mixed mesh support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted trailing whitespace
lots of stuff commented out
building with simmetrix and mpi enabled, ctest is failing the following tests: - diff_tri_convert - diff_tri_convert_numbering - run_mixed_test - periodic_test
- The diff was failing with this branch and master @ c5f1dc9. - The mesh toplogy and coordinates are the same for both meshes, but the local and global ids for vertices (didn't check other ents) created by omegah differs. I'm not sure why it doesn't match or if it matters to downstream applications. - For d3d-coreMesh-numbered-gold.osh, the numbering coming from simmetrix matches the prior 'gold' mesh.
fixed copy-paste error for pyramids
matthew-mccall
approved these changes
Jan 29, 2024
|
notes from offline discussion with @jacobmerson:
Switching this back to draft while the above changes are made. |
there is very little shared data between Mesh and MixedMesh as they have different storage and apis for tags and adjacency information
cwsmith
changed the title
|
In 2fd19f3 The |
the files are written without error, but paraview complains about incomplete class_id data
jacobmerson
approved these changes
Feb 15, 2024
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the support for mixed topology meshes (e.g.; a single mesh with tets + wedges) into a
MixedMeshclass. This will make merging changes from the sandialabs fork easier and will support upcoming work to add a 2d non-manifold model capability for simplex meshes (mono-topology).The most significant changes, that aren't just conditionals or moving code to new files, are in
Omega_h_meshsim.cppand how we create mixed or mono-topology meshes from simmetrix meshes. I refactored this code to create functions and structs that can are used in both mixed and mono-topology creation and use less memory.All tests are passing with MPI and Simmetrix SimModSuite enabled, and the Kokkos CUDA and Serial backends. Valgrind reports no errors or leaks in the tests (Kokkos Serial backend). Version details are below.
Note, the
periodic_testwas failing in master (#81) and the ctest was removed.OS: RHEL9,
checkersGCC: 12.3.0
CUDA: 12.1.1
SimModSuite: 2023.1-230907dev