Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe Improvements #79

Merged
merged 15 commits into from
Dec 22, 2023
Merged

Describe Improvements #79

merged 15 commits into from
Dec 22, 2023

Conversation

Angelyr
Copy link
Collaborator

@Angelyr Angelyr commented Dec 19, 2023

Related to this issue: #77 (comment)

In the describe tool, we should add the following info on each tag:

  • number of entities with a given values (this would require additional user input: tag name and value)
  • min and max across all processes
  • type (int, bool, float, real, etc.)
  • change ‘size per entity’ → ‘number of components’

@Angelyr Angelyr self-assigned this Dec 19, 2023
@Angelyr Angelyr requested a review from cwsmith December 20, 2023 18:01
Copy link

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few comments are below.

src/describe.cpp Outdated Show resolved Hide resolved
src/describe.cpp Outdated Show resolved Hide resolved
src/describe.cpp Outdated Show resolved Hide resolved
src/describe.cpp Show resolved Hide resolved
@Angelyr Angelyr requested a review from cwsmith December 22, 2023 01:24
@Angelyr Angelyr merged commit 8208a61 into master Dec 22, 2023
2 checks passed
@cwsmith cwsmith deleted the ac/describe-improvements branch January 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants