Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Building with Kokkos in Actions #72

Merged
merged 27 commits into from
Jan 11, 2024
Merged

Add Support for Building with Kokkos in Actions #72

merged 27 commits into from
Jan 11, 2024

Conversation

matthew-mccall
Copy link

@matthew-mccall matthew-mccall commented Nov 7, 2023 •
edited
Loading

This PR adds support for building with Kokkos and testing with and without the Kokkos memory pool.

@matthew-mccall matthew-mccall reopened this Nov 7, 2023
@matthew-mccall matthew-mccall force-pushed the kokkosWorkflow branch 3 times, most recently from 28d3b72 to 65c5e92 Compare November 7, 2023 19:17
@matthew-mccall matthew-mccall changed the title Add support for building with kokkos in actions Add Support for Building with Kokkos in Actions Nov 7, 2023
cwsmith
cwsmith approved these changes Nov 8, 2023
View reviewed changes
Copy link

@cwsmith cwsmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you.

edit: I just noticed this was a draft. What else did you want to add here? The CUDA build without testing? If so, I'm fine merging this as is or waiting for the remaining work.

@matthew-mccall
Copy link
Author

Yes, I was intending to add building with Kokkos with CUDA enabled, and building without Kokkos with Omega_h's CUDA backend.

@cwsmith
Copy link

cwsmith commented Nov 8, 2023

Yes, I was intending to add building with Kokkos with CUDA enabled, and building without Kokkos with Omega_h's CUDA backend.

Sounds good. Thank you. Until we officially deprecate the CUDA-only backend it is a good idea to make sure it still builds.

@matthew-mccall matthew-mccall marked this pull request as ready for review December 14, 2023 18:29
@matthew-mccall
Merge master into kokkosWorkflow
a3160d8 
commit f83c805
Merge: 8a187da 0ea05aa
Author: Cameron Smith <[email protected]>
Date:   Mon Dec 11 12:20:23 2023 -0500

    Merge pull request SCOREC#76 from SCOREC/cws/describeVerbose

    verbose mode to print per rank counts

commit 0ea05aa
Author: Cameron Smith <[email protected]>
Date:   Mon Dec 11 11:29:06 2023 -0500

    verbose mode to print per rank counts

commit 8a187da
Author: Cameron Smith <[email protected]>
Date:   Mon Dec 11 09:53:30 2023 -0500

    scorec-v10.8.4

commit 0b19ae4
Merge: 050c804 2ab0360
Author: Cameron Smith <[email protected]>
Date:   Mon Dec 4 13:20:47 2023 -0500

    Merge pull request SCOREC#75 from Angelyr/ac/describe-mesh

    Describe Mesh

commit 2ab0360
Author: Angelyr <[email protected]>
Date:   Fri Dec 1 16:19:28 2023 -0500

    print last mesh family

commit ee5b76a
Author: Angelyr <[email protected]>
Date:   Fri Dec 1 16:09:03 2023 -0500

    print mesh family

commit d568db0
Author: Angelyr <[email protected]>
Date:   Fri Dec 1 15:08:48 2023 -0500

    fixed test

commit 5ab2a22
Author: Angelyr <[email protected]>
Date:   Fri Dec 1 14:50:18 2023 -0500

    removed shapes

commit aedd985
Author: Angelyr <[email protected]>
Date:   Thu Nov 30 17:56:24 2023 -0500

    one test

commit 3fd509e
Author: Angelyr <[email protected]>
Date:   Thu Nov 30 17:40:31 2023 -0500

    test print

commit f6d62c7
Author: Angelyr <[email protected]>
Date:   Thu Nov 30 17:34:14 2023 -0500

    print one comm rank at a time

commit 1c04fc4
Author: Angelyr <[email protected]>
Date:   Thu Nov 30 15:27:59 2023 -0500

    size per entity

commit ac7d4ab
Author: Angelyr <[email protected]>
Date:   Thu Nov 30 15:25:32 2023 -0500

    describe test

commit 92a7449
Author: Angelyr <[email protected]>
Date:   Wed Nov 29 15:39:44 2023 -0500

    rename file

commit 1cfe254
Author: Angelyr <[email protected]>
Date:   Wed Nov 29 15:28:28 2023 -0500

    refactor size

commit 382fb8f
Author: Angelyr <[email protected]>
Date:   Wed Nov 29 15:24:04 2023 -0500

    better fields

commit f0c5ffe
Author: Angelyr <[email protected]>
Date:   Wed Nov 29 14:37:27 2023 -0500

    more comments

commit c8a511a
Author: Angelyr <[email protected]>
Date:   Tue Nov 28 18:34:13 2023 -0500

    printing tag name

commit 660b36a
Author: Angelyr <[email protected]>
Date:   Tue Nov 28 16:43:01 2023 -0500

    printing more fields

commit b39eeb6
Author: Angelyr <[email protected]>
Date:   Tue Nov 28 15:42:48 2023 -0500

    print mesh entities

commit 050c804
Merge: 90bf005 124d390
Author: Cameron Smith <[email protected]>
Date:   Wed Nov 15 14:43:47 2023 -0500

    Merge pull request SCOREC#74 from SCOREC/cws/simModSuiteLatest

    support latest version of simmodsuite and rhel8 systems

commit 124d390
Author: Cameron Smith <[email protected]>
Date:   Mon Nov 13 15:35:42 2023 -0500

    remove another debug print

commit 3f0923c
Author: Cameron Smith <[email protected]>
Date:   Mon Nov 13 15:35:12 2023 -0500

    remove debug print

commit 8967cc2
Author: Cameron Smith <[email protected]>
Date:   Fri Nov 10 15:43:10 2023 -0500

    silence cmake warning

commit f2b1d60
Author: Cameron Smith <[email protected]>
Date:   Fri Nov 10 15:41:09 2023 -0500

    support rhel8

commit bddc30f
Author: Cameron Smith <[email protected]>
Date:   Fri Nov 10 15:34:21 2023 -0500

    support serial build with simmodsuite

commit fabcd53
Author: Cameron Smith <[email protected]>
Date:   Thu Nov 9 21:56:24 2023 -0500

    support simmodsuite 2023.1-231028

commit 90bf005
Merge: b34ea58 4a9ef03
Author: Cameron Smith <[email protected]>
Date:   Thu Nov 9 19:49:19 2023 -0500

    Merge pull request SCOREC#73 from ikalash/master

    Fixes to prevent compilation errors in Albany warning-free build.

commit 4a9ef03
Author: Irina Tezaur <[email protected]>
Date:   Thu Nov 9 15:03:06 2023 -0700

    Implementing change suggested by Luca.

commit 2d91178
Author: Irina Tezaur <[email protected]>
Date:   Thu Nov 9 13:39:46 2023 -0700

    Fixes to prevent compilation errors in Albany warning-free build.

commit b34ea58
Merge: d932d7f 04fca4e
Author: Cameron Smith <[email protected]>
Date:   Tue Nov 7 15:26:48 2023 -0500

    Merge pull request SCOREC#71 from bartgol/bartgol/add-lib-alias

    Make Omega_h::omega_h alias available during build

commit 04fca4e
Author: Luca Bertagna <[email protected]>
Date:   Tue Nov 7 11:41:47 2023 -0700

    Make Omega_h::omega_h alias available during build

    Allows a downstream app to link against Omega_h::omega_h,
    regardless of whether Omega_h is used as a found dependency
    (via find_package) or as a sub-project (e.g., via FetchContent)
@matthew-mccall
Fix Print step
1fedae5
@matthew-mccall
Merge branch 'master' into kokkosWorkflow
9731fa6
@matthew-mccall
Remove unused workflow steps
2146fe5
@cwsmith
Copy link

cwsmith commented Jan 11, 2024

@matthew-mccall Is this all set?

@matthew-mccall
Copy link
Author

Besides support for building, Omega_h with CUDA and without Kokkos (which seems to be an issue with the Omega_has source which is likely out of the scope of this PR), yes.

@cwsmith
Copy link

cwsmith commented Jan 11, 2024

OK. Sounds good. I'll merge this. Thank you!

@cwsmith cwsmith merged commit c5f1dc9 into SCOREC:master Jan 11, 2024
8 checks passed
@matthew-mccall matthew-mccall deleted the kokkosWorkflow branch January 30, 2024 01:55
@cwsmith cwsmith mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwsmith cwsmith cwsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew-mccall @cwsmith