shape_test fails with cpu serial backend build (kokkos disabled)

[cwsmith]

See:
https://github.com/SCOREC/omega_h/actions/runs/9503127985/job/26192823407#step:11:12347

[cwsmith]

The latest failure:

shape_test: /home/runner/work/omega_h/omega_h/omega_h/src/shape_test.cpp:20: void check_point(const Omega_h::Matrix<2, 3>&): Assertion `are_close(xi,hand_xi)' failed.

is with the following config:

Compiler: g++
g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

MPI: off
Kokkos: on
Memory Pool: off

Using Ubuntu 22.04 and GCC 11.4.0 the error can be reproduced.

The failure is not deterministic; with the same build, some runs will pass.

Stack:

(ins)(gdb) r
Starting program: /home/cws/dev/buildOmegahKkSerial/src/shape_test 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[1.000000,0.000000,-0.000000] == [1.000000,0.000000,0.000000]
[0.000000,1.000000,0.000000] == [0.000000,1.000000,0.000000]
[0.000000,0.000000,1.000000] == [0.000000,0.000000,1.000000]
[0.000000,0.000000,1.000000] == [0.250000,0.250000,0.500000]
shape_test: /home/cws/dev/omega_h/src/shape_test.cpp:20: void check_point(const Omega_h::Matrix<2, 3>&): Assertion `are_close(xi,hand_xi)' failed.

Program received signal SIGABRT, Aborted.
__pthread_kill_implementation (no_tid=0, signo=6, threadid=140737352721344) at ./nptl/pthread_kill.c:44
44	./nptl/pthread_kill.c: No such file or directory.
(ins)(gdb) where
#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=140737352721344) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=140737352721344) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=140737352721344, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007ffff7842476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007ffff78287f3 in __GI_abort () at ./stdlib/abort.c:79
#5  0x00007ffff782871b in __assert_fail_base (fmt=0x7ffff79dd130 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x55555555915f "are_close(xi,hand_xi)", 
    file=0x5555555590e0 "/home/cws/dev/omega_h/src/shape_test.cpp", line=20, function=<optimized out>) at ./assert/assert.c:92
#6  0x00007ffff7839e96 in __GI___assert_fail (assertion=0x55555555915f "are_close(xi,hand_xi)", file=0x5555555590e0 "/home/cws/dev/omega_h/src/shape_test.cpp", line=20, 
    function=0x555555559130 "void check_point(const Omega_h::Matrix<2, 3>&)") at ./assert/assert.c:101
#7  0x0000555555555770 in check_point (coords=...) at /home/cws/dev/omega_h/src/shape_test.cpp:20
#8  0x00005555555559a7 in main (argc=1, argv=0x7fffffffe0b8) at /home/cws/dev/omega_h/src/shape_test.cpp:28

[cwsmith]

fixed with 7c2ba19