Giulio benedini/plot grid molecules #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dormrod
reviewed
Jan 10, 2025
| ) | ||
|
|
||
| if save_svg_path is not None: | ||
| if not isinstance(img, str): |
There was a problem hiding this comment.
N.B. updated this as I wouldn't use assert in production code
dormrod
force-pushed
the
GiulioBenedini/plot_grid_molecules
branch
from
1ce66d0 to
1a7f8cb
Compare
|
Just remember to update the changelog also. Your image also did look low quality as per your comment, but all the tests passed using the bigger image I uploaded, so I wonder if that is to do with your config somehow? |
added 3 commits
January 10, 2025 18:58
I have now updated the changelog. You are probably right, but I do not know what is the cause yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an interface to rdkit Draw.MolsToGridImage called plot_grid_molecules.