Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompts: Expose all core functions #1238

Merged
merged 1 commit into from
May 29, 2023

Conversation

LitoMore
Copy link
Collaborator

@LitoMore LitoMore commented May 27, 2023

This exposes all core functions to @inqurier/prompts.

I believe some people will use our built-in prompts and their self-made prompts at the same time.

In this case, allowing them access to our core functions with inquirer/prompts is better.

In the future, we can provide and expose more utility functions in this way.

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b7447a8) 81.49% compared to head (3fb152f) 81.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1238   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files          39       39           
  Lines        4663     4663           
  Branches      677      677           
=======================================
  Hits         3800     3800           
  Misses        193      193           
  Partials      670      670           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LitoMore LitoMore requested a review from SBoudrias May 27, 2023 15:20
@SBoudrias SBoudrias merged commit f4bd864 into SBoudrias:master May 29, 2023
@SBoudrias
Copy link
Owner

Good call, I think that's aligned with the goals of the new version.

@LitoMore LitoMore deleted the export-core-library branch May 29, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants