-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template.py: make filter warnings conditional and allow for no ctf_params #98
Conversation
Thanks for the PR to address it! I was thinking it might be better if there is no warning message if the filter is not set.
|
You are right, was my preferred solution as well 👍 I altered it to that, please have another look |
Co-authored-by: Marten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
replaces #88
I got a question from a novice user that thought it was bad when he did not specify the lowpass filter.
This now makes the log message conditional to the input
During the writing of the test I saw that there was code handeling
ctf_params=None
(line 73), so I added that option as a default to the call as well