calculate spectrum whitening filter only in the search region #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you add a test? (probably a quick one that checks if the saved whitening filter has the expected dimensions?) LGTM otherwise |
… to calculate and it wont bug if the search size of the tomogram is changed
|
Test is added! I also switched to recalculating the whitening filter in TMJob's. Since version 0.3.3 its fast to calculate and this will prevent
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch to only calculate the whitening filter in the user specified search region. Edges of reconstructions can often have reconstruction/interpolation artifacts that users might want to avoid. The whitening filter should also not take them into account as the data here does not contain reliable info about the signal to noise ratio of the tomogram.