Terminate other processes if one breaks #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroet
requested changes
Jan 9, 2024
…r breaking the job
|
Not done yet, will let you know when ready ;) |
…ding output during unittesting
|
Okay, good to go for my part! I added in a stdout/stderr muting option for spawning processes during unit tests to prevent the terminal showing an error message during the tests. Let me know if you agree with how I did that. |
sroet
requested changes
Jan 9, 2024
…st_mute to make it explicit that this is purely for testing
sroet
requested changes
Jan 10, 2024
Co-authored-by: Sander Roet <[email protected]>
|
Thanks for spotting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a multiprocessing problem (unrelated to #74). When one of the processes fails, the other will keep running. This is undesired as the results will become unusable. Now I explicitly terminate all processes when one fails before raise a runtimeerror in the main process.
(I previsouly thought that 'raise RuntimeError' would be propagated to child processes, but that is apparently not the case)