Patch band pass unassigned #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the filter generation in the start of the template matching job to make it respond properly to input -- users should be able to apply a bandpass filter without providing tilt angles
sroet
requested changes
Nov 10, 2023
Co-authored-by: Sander Roet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be part of the bugfixes for version 0.3.2. It solves issue #61.
I updated the tomogram (
tomogram_filter) and template weighting generation (template_wedge) inTMJob.start_job()to solve this issue. After the addition of the spectrum whitening there are now quite some weighting options: a band-pass, a whitening-filter, and a wedge filter. They are optional but should also work together.To make it more logical both weighting are now initialized as 1, and are multiplied with all the optional filters in when the respective flags are set. If they remain 1 (no filter flags are set) they will not modify the tomogram/template.
I updated the tests to run the job with combinations of these weighting options.
Also removed some debug volume writing as it interfered with clean up of the test data now that I made the filter creation more logical.
I am a bit uncertain about the fact that in
test_weights.pyI have some variables that store general data (CTF, dose accumulation) and load this from this file intotest_tmjob.py, is that okay to do?