Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom angular sampling #56

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Allow custom angular sampling #56

merged 3 commits into from
Nov 1, 2023

Conversation

McHaillet
Copy link
Collaborator

This is a small change (and the last for now) to allow users to provide their own set of rotations to search the tomogram with.

@McHaillet McHaillet requested a review from sroet November 1, 2023 14:18
sroet
sroet requested changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a test so that this option stays available in future development

@McHaillet
Copy link
Collaborator Author

good point, added it in 👍

sroet
sroet approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to merge

@McHaillet McHaillet merged commit 0fb6ce1 into SBC-Utrecht:main Nov 1, 2023
@McHaillet McHaillet deleted the allow_custom_angular_sampling branch November 1, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroet sroet sroet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McHaillet @sroet