reduce angular search space by applying symmetry #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McHaillet
changed the title
sroet
requested changes
Nov 1, 2023
There was a problem hiding this comment.
Please use slightly less obscure ways to round up 😅
Can this still be part of the 0.3.0 version or should I increase th version number?
I don't see breaking changes, so feel free to keep the version number as is. Also, normally the version is only "locked-in" after a proper release has been done. So no need to update it further (even for breaking changes) untill we do another proper release (by tagging it and drafting it in here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29
I added a small option to reduce angular search space for n-fold symmetrical particles.
Can this still be part of the 0.3.0 version or should I increase th version number?