-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relion5 input #229
Relion5 input #229
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against c9ffc02 |
I added unittests and fixed reading of the tomogram handedness. It's ready for review 👍 Also just added version number update to 0.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 missing test, couple other issues/corner cases. LGTM otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, LGTM
Closes #190
@Phaips @rdrighetto also adding you here, in case you have ideas about the implementation for this.
I made a PR to tackle the RELION5 metadata input. I tested it on a RELION5 project I made from the frames of the tutorial. As it is now, it runs and gives expected results. It does make the input quite easy as the job can be started like this and all 3D-CTF data is fetched from the relion metadata:
pytom_match_template.py -t Templates/80S_14A.mrc -m Templates/mask.mrc -v Tomograms/job006/tomograms/rec_tomo200528_102.mrc --particle-diameter 300 --relion5-tomograms-star Tomograms/job006/tomograms.star -d TemplateMatching/ -g 0
If one would want to loop over all the tomograms in the RELION directory you could do something like this in bash:
for tomo in Tomograms/job006/tomograms/*.mrc; do pytom_match_template.py -t Templates/80S_14A.mrc -m Templates/mask.mrc -v "$tomo" --particle-diameter 300 --relion5-tomograms-star Tomograms/job006/tomograms.star -d TemplateMatching/ -g 0; done
This PR is still a draft because I need to add unit tests and tackle the defocus handedness parameter from RELION. I am not sure if it actually applies a flip to the images.
It also made me aware that the code could be improved using some sort of TiltSeries struct internally that associates all the tilt angles, CTF and dose. But, better left for later to not convolute this.