Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bins option to both the tophat and extraction plot #227

Merged
merged 9 commits into from
Aug 29, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Aug 23, 2024

closes #113

Also:

  • rewrites the tmjob tests to use a temp directory
  • updates minimal coverage to 88%
  • updates version to 0.7.3

Parts:

  • add options to code
  • add options to the entry point(s)
  • add tests

Copy link

github-actions bot commented Aug 23, 2024

File Coverage Missing
All files 89%
src/pytom_tm/correlation.py 85% 98-99 131
src/pytom_tm/entry_points.py 79% 28 113-130 235-280 385-404 557-577 1057-1068
src/pytom_tm/extract.py 97% 265-270
src/pytom_tm/io.py 81% 20 40 58 76 89 110-116 133-137 144 150 162 169 216-218 288 434-442 467
src/pytom_tm/mask.py 80% 76 94 104-105
src/pytom_tm/parallel.py 89% 14-15 93 104-105 111 176
src/pytom_tm/plotting.py 16% 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-397
src/pytom_tm/tmjob.py 97% 372-373 389 399-404 483 611 660
src/pytom_tm/utils.py 78% 18-20
src/pytom_tm/weights.py 96% 59 314-318 325 535 540 545

Minimum allowed coverage is 87%

Generated by 🐒 cobertura-action against dc7ce64

@sroet sroet marked this pull request as ready for review August 29, 2024 13:05
@sroet sroet requested review from FridoF and McHaillet August 29, 2024 13:05
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving! Just had a question about what breaks the import for my own understanding

tests/testzz_broken_imports.py Show resolved Hide resolved
@sroet sroet merged commit b6c4a93 into SBC-Utrecht:main Aug 29, 2024
2 checks passed
@sroet sroet deleted the allow_for_change_of_bins branch August 29, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add command line option for number of bins for extraction graph/tophat graph
2 participants