Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tutorial-tests.yml working #226

Merged
merged 26 commits into from
Aug 19, 2024
Merged

Get tutorial-tests.yml working #226

merged 26 commits into from
Aug 19, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Aug 16, 2024

Alright, I am rerunning this job only on this branch until I get it working

closes #148

Copy link

github-actions bot commented Aug 16, 2024

File Coverage Missing
All files 88%
src/pytom_tm/correlation.py 85% 98-99 131
src/pytom_tm/entry_points.py 79% 28 113-130 235-280 385-404 540-558 1038-1049
src/pytom_tm/extract.py 76% 127-138 205-212 256-261 354-372
src/pytom_tm/io.py 81% 20 40 58 76 89 110-116 133-137 144 150 162 169 216-218 288 434-442 467
src/pytom_tm/mask.py 80% 76 94 104-105
src/pytom_tm/parallel.py 89% 14-15 93 104-105 111 176
src/pytom_tm/plotting.py 16% 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-397
src/pytom_tm/tmjob.py 97% 372-373 389 399-404 483 611 660
src/pytom_tm/utils.py 78% 18-20
src/pytom_tm/weights.py 96% 59 314-318 325 535 540 545

Minimum allowed coverage is 87%

Generated by 🐒 cobertura-action against dee2f0a

@sroet sroet changed the title reset working directory install step tutorial-tests.yml Get tutorial-tests.yml working Aug 19, 2024
@sroet sroet marked this pull request as ready for review August 19, 2024 10:03
@sroet
Copy link
Collaborator Author

sroet commented Aug 19, 2024

@McHaillet This finally works! It runs in 101 min, and can be seen here: https://github.com/SBC-Utrecht/pytom-match-pick/actions/runs/10425169098/job/28875465809 (commit 4ba5eda, which failed on ruff stuff in the regular unitests)

With that runtime, it might be worthwhile to actually pip install cupy, what do you think?

@sroet sroet requested review from FridoF and McHaillet August 19, 2024 10:06
@sroet
Copy link
Collaborator Author

sroet commented Aug 19, 2024

It also already found the first error in the tutorial 😅

Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@McHaillet
Copy link
Collaborator

It also already found the first error in the tutorial 😅

Nice! What was the error?

@sroet
Copy link
Collaborator Author

sroet commented Aug 19, 2024

It also already found the first error in the tutorial 😅

Nice! What was the error?

the file you get from emdb is called emd_2938.map instead of emd_2938.mrc (was mentioned that way in the file structure)

@sroet sroet merged commit 59d3fc5 into main Aug 19, 2024
2 checks passed
@sroet sroet deleted the sroet-patch-1 branch August 19, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test the tutorial
2 participants