Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with new ruff version and next try for tutorial-test.yml #224

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Aug 15, 2024

this is the next try at testing the tutorial, will now only trigger on pushes to main.
(will have to merged before it triggers)

might solve #148

Also tries to fix the ruff issues with the added ipynb (a new ruff version has released with ipynb linting enabled) and updates the pre-commit hook

Also updates minimal coverage to 87%

@sroet sroet requested review from FridoF and McHaillet August 15, 2024 12:50
@sroet sroet marked this pull request as draft August 15, 2024 13:18
@sroet sroet changed the title next try at tutorial-tests.yml next try at tutorial-tests.yml and fix ruff benchmark issues Aug 15, 2024
@sroet sroet changed the title next try at tutorial-tests.yml and fix ruff benchmark issues deal with new ruff version and next try for tutorial-test.yml Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

File Coverage Missing
All files 88%
src/pytom_tm/correlation.py 85% 98-99 131
src/pytom_tm/entry_points.py 79% 28 113-130 235-280 385-404 540-558 1038-1049
src/pytom_tm/extract.py 76% 127-138 205-212 256-261 354-372
src/pytom_tm/io.py 81% 20 40 58 76 89 110-116 133-137 144 150 162 169 216-218 288 434-442 467
src/pytom_tm/mask.py 80% 76 94 104-105
src/pytom_tm/parallel.py 89% 14-15 93 104-105 111 176
src/pytom_tm/plotting.py 16% 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-397
src/pytom_tm/tmjob.py 97% 372-373 389 399-404 483 611 660
src/pytom_tm/utils.py 78% 18-20
src/pytom_tm/weights.py 96% 59 314-318 325 535 540 545

Minimum allowed coverage is 86%

Generated by 🐒 cobertura-action against eb44e3f

@sroet sroet marked this pull request as ready for review August 15, 2024 13:57
@@ -13,8 +13,8 @@
"import numpy as np\n",
"from scipy.spatial.distance import cdist\n",
"from scipy.optimize import curve_fit\n",
"from scipy.stats import t\n",
"sns.set(style='ticks', context='notebook')"
"\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all the double quotes also need to be escaped?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, they are inside double quotes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the double quotes and \n is how an ipynb looks like outside of jupyter

@sroet sroet requested a review from McHaillet August 15, 2024 14:12
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and anyway need to try the workflow

@sroet sroet merged commit c8b0f6a into main Aug 16, 2024
2 checks passed
@sroet sroet deleted the sroet-patch-1 branch August 16, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants