-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deal with new ruff version and next try for tutorial-test.yml #224
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against eb44e3f |
@@ -13,8 +13,8 @@ | |||
"import numpy as np\n", | |||
"from scipy.spatial.distance import cdist\n", | |||
"from scipy.optimize import curve_fit\n", | |||
"from scipy.stats import t\n", | |||
"sns.set(style='ticks', context='notebook')" | |||
"\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do all the double quotes also need to be escaped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, they are inside double quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the double quotes and \n is how an ipynb looks like outside of jupyter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and anyway need to try the workflow
this is the next try at testing the tutorial, will now only trigger on pushes to main.
(will have to merged before it triggers)
might solve #148
Also tries to fix the ruff issues with the added ipynb (a new ruff version has released with ipynb linting enabled) and updates the pre-commit hook
Also updates minimal coverage to 87%