-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: calculate subvolume defocus values #217
feature: calculate subvolume defocus values #217
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against ed489e6 |
2585201
to
2b7afca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues and feedback.
Other points:
- Would this need an option to override the tilt-axis? Or are those always "close enough" to the y-axis?
<figure markdown="span"> | ||
{ width="400" } | ||
<figcaption>Initial view of the data: annotations (turqoise sphere) made by | ||
pytom-match-pick on tomogram 27 of EMPIAR-10985.</figcaption> | ||
</figure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems broken in github MD rendering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is not supported in native markdown: https://squidfunk.github.io/mkdocs-material/reference/images/#image-captions
The md_in_html extension (in the mkdocs.yml) enables it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the captions are not supported
Co-authored-by: Sander Roet <[email protected]>
The tilt axis of the tilt series is always aligned with the y-axis of the tomogram. It's the common convention as far as I know. So should be safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! LGTM!
This PR adds support for calculating defocus value for each subvolume specified with
--volume-split
in template matching. As particles experience a different defocus based on their position in the ice and depending on the tilt angle, this potentially provides detailed defocus gradient correction. However, I also added a page on the site with a benchmark for measuring the effects of defocus gradient correction and found that the effect is very small. I thought this would be cool to add.