Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add E501 check #216

Merged
merged 2 commits into from
Aug 14, 2024
Merged

add E501 check #216

merged 2 commits into from
Aug 14, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Aug 13, 2024

closes #215

  • enable tests
  • fix new issues

@sroet sroet marked this pull request as ready for review August 13, 2024 16:02
@sroet sroet requested a review from McHaillet August 13, 2024 16:02
@sroet
Copy link
Collaborator Author

sroet commented Aug 13, 2024

@McHaillet mostly style changes, did restructure some strings to f-strings instead of using format, pasted in some angsrom symbols (Å) and reworded some sentences

@sroet sroet requested a review from FridoF August 13, 2024 16:03
Copy link

File Coverage Missing
All files 87%
src/pytom_tm/correlation.py 85% 98-99 131
src/pytom_tm/entry_points.py 79% 28 111-128 231-276 379-398 532-550 998-1009
src/pytom_tm/extract.py 76% 127-138 205-212 256-261 353-371
src/pytom_tm/io.py 80% 20 40 58 76 89 110-116 133-137 144 150 162 169 216-218 288 325-328 433-441 466
src/pytom_tm/mask.py 80% 76 94 104-105
src/pytom_tm/parallel.py 89% 14-15 93 104-105 111 176
src/pytom_tm/plotting.py 16% 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-397
src/pytom_tm/tmjob.py 97% 309-310 326 336-341 420 542 591
src/pytom_tm/utils.py 78% 18-20
src/pytom_tm/weights.py 96% 59 314-318 325 535 540 545

Minimum allowed coverage is 86%

Generated by 🐒 cobertura-action against 4417c8d

@McHaillet
Copy link
Collaborator

@McHaillet mostly style changes, did restructure some strings to f-strings instead of using format, pasted in some angsrom symbols (Å) and reworded some sentences

I will have a look now!

Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for adding @sroet!

@McHaillet McHaillet merged commit e28e155 into SBC-Utrecht:main Aug 14, 2024
2 checks passed
@sroet sroet deleted the add_e501_check branch August 14, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ruff E501 to format comments and docstrings
2 participants