New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check on tomo mask shape #210

Merged

sroet merged 5 commits into SBC-Utrecht:main from sroet:check_pixels_tomo_mask

Aug 7, 2024

Collaborator

sroet commented Aug 7, 2024 •

edited

Loading

closes #194
(the part that the tm-job should error out if the mask is the wrong size)

Also adds the same check to the extraction job

add checks to catch mismatch between tomo mask and tomogram in tmjob
as above for extraction
alter tooltips to mention number of pixels
add tests


          add check on tomo mask shape

cac21af

github-actions bot commented Aug 7, 2024 •

edited

Loading

File	Coverage		Missing
All files	`87%`	✅
src/pytom_tm/correlation.py	`85%`	❌	`97-98` `129`
src/pytom_tm/entry_points.py	`79%`	❌	`28` `111-128` `231-276` `379-398` `531-549` `996-1007`
src/pytom_tm/extract.py	`76%`	❌	`122-133` `198-205` `247-252` `344-362`
src/pytom_tm/io.py	`80%`	❌	`19` `40` `58` `76` `88` `108-115` `131-135` `143` `150` `161` `168` `214-216` `280` `316-319` `420-428` `453`
src/pytom_tm/mask.py	`80%`	❌	`72` `90` `100-101`
src/pytom_tm/parallel.py	`89%`	✅	`14-15` `89` `100-101` `107` `170`
src/pytom_tm/plotting.py	`16%`	❌	`19-21` `24-31` `35-43` `47-50` `53-69` `72-73` `76-77` `97-102` `118-126` `132-149` `164-172` `176-193` `197-205` `209-216` `222` `228` `233` `247-395`
src/pytom_tm/tmjob.py	`97%`	✅	`301-302` `318` `327-331` `403` `524` `568`
src/pytom_tm/utils.py	`78%`	❌	`17-19`
src/pytom_tm/weights.py	`96%`	✅	`57` `304-307` `314` `519` `524` `529`

Minimum allowed coverage is 86%

Generated by 🐒 cobertura-action against 6973b66

sroet added 4 commits

August 7, 2024 16:42


          make f-string and add test also in extraction

f09e96f


          add tests for the errors

89060c2


          update tooltips to mention that the dimensions should be in pixels

cbaff24


          use correct input name

6973b66

sroet marked this pull request as ready for review

August 7, 2024 15:02

sroet requested review from FridoF and McHaillet

August 7, 2024 15:02

McHaillet approved these changes

View reviewed changes

Collaborator

McHaillet left a comment

Thanks for the fix. LGTM!

sroet merged commit 6de4c01 into SBC-Utrecht:main

2 checks passed

sroet deleted the check_pixels_tomo_mask branch

August 7, 2024 20:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet