Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: add int type for rng seed #192

Merged
merged 5 commits into from
Jul 5, 2024
Merged

bug fix: add int type for rng seed #192

merged 5 commits into from
Jul 5, 2024

Conversation

McHaillet
Copy link
Collaborator

@McHaillet McHaillet commented Jun 21, 2024 •
edited
Loading

Closes #191

  • But should still add a test for it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 21, 2024 •
edited
Loading

File Coverage Missing
All files 87% ✅
src/pytom_tm/correlation.py 85% ❌ 97-98 129
src/pytom_tm/entry_points.py 79% ❌ 28 105-122 220-265 354-372 490-507 941-952
src/pytom_tm/extract.py 75% ❌ 122-133 193-200 235-240 332-350
src/pytom_tm/io.py 80% ❌ 19 40 58 76 88 108-115 131-135 143 150 161 168 214-216 280 316-319 420-428 453
src/pytom_tm/mask.py 80% ❌ 72 90 100-101
src/pytom_tm/parallel.py 89% ✅ 14-15 89 100-101 107 170
src/pytom_tm/plotting.py 16% ❌ 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-395
src/pytom_tm/tmjob.py 97% ✅ 301-302 318 327-331 398 519 563
src/pytom_tm/utils.py 78% ❌ 17-19
src/pytom_tm/weights.py 96% ✅ 57 304-307 314 519 524 529

Minimum allowed coverage is 86%

Generated by 🐒 cobertura-action against 4ec61d7

@McHaillet McHaillet marked this pull request as ready for review June 28, 2024 10:50
@McHaillet McHaillet requested a review from sroet June 28, 2024 10:50
sroet
sroet requested changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One double line of code, LGTM otherwise!

tests/test_entry_points.py Outdated Show resolved Hide resolved
@McHaillet @sroet
Fix: remove double line
4ec61d7 
Co-authored-by: Sander Roet <[email protected]>
@McHaillet McHaillet requested a review from sroet July 5, 2024 16:12
sroet
sroet approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@McHaillet McHaillet merged commit 2e89746 into main Jul 5, 2024
2 checks passed
@McHaillet McHaillet deleted the McHaillet-patch-1 branch July 5, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroet sroet sroet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError in match_template
2 participants
@McHaillet @sroet