-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tutorial test yml #187
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 49e0701 |
@McHaillet as with #118 this will not work properly before it is actually in the main repo due to the way the protections are set up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My main concern is that running all the tutorial commands takes some time, a rough guess would be ~40 mins (to give a ballpark). Perhaps we could require the tutorial to run before releasing a new version to pypi.
BTW not specifically requesting to change (should have made this review comment), but just wanted to discuss this point.
Understandable, we can also just run it on the weekly builds if you want. First wanted just to see if it actually runs (and in what time) |
Alright, that sounds good :) |
closes #148
For now this does not include coverage
It uses repo secrets for pulling from dataverse, which means it has to be spawned like the coverage comment workflow
It walks through the tutorial file, grabs all code blocks and executes them if they start with
*.py