-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phase randomization score map correction #182
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against a7f2ec1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general comment:
min coverage should be increased to 86already done in fix symmetry bug #184
Other than that, one default question, one proposed refactor, one doc suggestion, one code consistency thing
Once this one is merged, I would like make a PR to throw the code through ruff and maybe set up a pre-commit thingy.
Sounds good, I can also look into that if you don't have time for that (isn't necessary 'publishable' 😉 ), just tag me into an issue
Also fine, will respond in the PR I made for it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge
This PR adds 'phase randomization', introduced by STOPGAP.
Explanation of what this is: The match_template command line got two additional arguments: one flag to activate this mode, another to set a seed for randomization. The seed is used to create a phase randomized version of the template, meaning the phases of the Fourier transform are randomly permuted (used often for FSC calculations). This second template is like a random noise object and is matched simultaneously with the original template. The score map of the noisy version is subtracted from the real one.
With the particle diameter updated and ctf input reworked, this is the last thing I really want to add in functionality-wise.
Once this one is merged, I would like make a PR to throw the code through ruff and maybe set up a pre-commit thingy.