-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center of mass fix #179
Center of mass fix #179
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against e624fc7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One preference, feel free to ignore. LGTM otherwise
I am not fully sure about the unittest check yet though, maybe you have a better solution.
Current implementation looks good
One other solution might be to compare np.abs(generate_template_from_map(template, ...)
and generate_template_from_map(np.abs(template), ...)
which should be identical
Co-authored-by: Sander Roet <[email protected]>
I added this in. Will merge once the tests pass. |
Fix for the center of mass. I am not fully sure about the unittest check yet though, maybe you have a better solution. Currently checking with the same method as I am using internally.
I also switched to box padding after recentering. That is the better order as the padding is anyway done with zeros.
Closes #173
The square seems to work nicely though. This is an example that was failing before:
And now works much better: