New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make template non-symmetrical for template matching test to prevent race condition #169

Merged

McHaillet merged 2 commits into main from McHaillet-patch-1

May 8, 2024

Collaborator

McHaillet commented May 8, 2024 •

edited

Loading

I think this should solve it.

I'll wait for the tests to pass


          make template non-symmetrical for template matching test to prevent o…

7c562bb

…rientation race condition

sroet approved these changes

View reviewed changes

Collaborator

sroet left a comment

LGTM! thanks for looking into this! feel free to merge on green


          different template changes standard deviation, so adjust accordingly

59715ab

Collaborator Author

McHaillet commented May 8, 2024

standard deviation changed, so had to update the test values

github-actions bot commented May 8, 2024

File	Coverage		Missing
All files	`81%`	✅
src/pytom_tm/angles.py	`94%`	✅	`44`
src/pytom_tm/correlation.py	`85%`	✅	`94-95` `126`
src/pytom_tm/entry_points.py	`70%`	❌	`27` `104-121` `290-350` `439-454` `564-580` `829-897` `938-949`
src/pytom_tm/extract.py	`73%`	❌	`110-121` `176-183` `209-212` `284-302`
src/pytom_tm/io.py	`48%`	❌	`15-19` `25-28` `34-37` `43-46` `52-55` `62-66` `74-87` `93-100` `107-114` `129-131` `184` `218-219` `261-263` `279` `295` `312-321` `341-346`
src/pytom_tm/mask.py	`80%`	✅	`70` `85` `94-95`
src/pytom_tm/parallel.py	`84%`	✅	`14-15` `81-87` `95-97` `104` `109` `148`
src/pytom_tm/plotting.py	`16%`	❌	`20-22` `25-32` `36-44` `48-51` `54-70` `73-74` `77-78` `98-103` `119-127` `133-150` `165-173` `177-194` `198-206` `210-217` `223` `229` `234` `248-398`
src/pytom_tm/template.py	`57%`	❌	`57-58` `67` `76-87` `92-97` `107-112` `114`
src/pytom_tm/tmjob.py	`96%`	✅	`177-178` `190` `196-198` `201` `334` `374`
src/pytom_tm/utils.py	`78%`	❌	`16-18`
src/pytom_tm/weights.py	`96%`	✅	`61` `292-293` `300` `480` `483` `486`

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 59715ab

McHaillet merged commit 7281be2 into main

2 checks passed

McHaillet deleted the McHaillet-patch-1 branch

May 8, 2024 12:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet