small speedboost by precalculating conjugation #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7b61153 |
sroet
requested changes
May 7, 2024
There was a problem hiding this comment.
Looks reasonable to me, couple points:
- one surprise with performance
- this breaks API so should invoke version 0.7.0 instead of the current next release of 0.6.0
- One line was changed that was not covered in our current tests, please add a test to cover that line 😄
Co-authored-by: Sander Roet <[email protected]>
sroet
requested changes
May 7, 2024
|
Woops this didn't fix it yet |
McHaillet
commented
May 7, 2024
|
I set precision to 4 for the standard deviation. interpolation of the spherical mask upon rotation slightly changes the mask, meaning the eventual scores won't be identical. It should still be very close and that is indeed true. |
|
Its fixed now. The lines are hit! |
|
Needed to merge changes from main to make it mergeable. Lets see if they now pass. |
sroet
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to improve the speed a bit more and setup a few things to allow easier implementation of phase randomization.
Conjugated rft's of the tomogram are precalculated (instead of template conjugation). This requires some different shifting of the output score map and a different mask for calculating the score map standard deviation (hence some changes there).
Results are consistent with previous implementation and all the tests pass.
also closes #103