Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase plate ctf and argparse grouping #157

Merged
merged 14 commits into from
Apr 5, 2024

Conversation

McHaillet
Copy link
Collaborator

@McHaillet McHaillet commented Apr 4, 2024

In this PR I added the following:

  • grouping of argparse parameters for pytom_match_template.py to make the help more readable!
  • a phase shift parameter for CTF curves, with allows users to model a phase plate. Phase shift calculation follows standard conventions.

For the phase shift parameter I had to make job reading backwards compatible, so I added another version based check.

Closes #150 and closes #76

@McHaillet McHaillet requested a review from sroet April 4, 2024 15:38
Copy link

github-actions bot commented Apr 4, 2024

File Coverage Missing
All files 80%
src/pytom_tm/angles.py 94% 44
src/pytom_tm/correlation.py 85% 94-95 126
src/pytom_tm/entry_points.py 70% 27 104-121 290-350 439-454 551-566 814-882 923-934
src/pytom_tm/extract.py 73% 107-118 170-176 202-205 277-295
src/pytom_tm/io.py 48% 15-19 25-28 34-37 43-46 52-55 62-66 74-87 93-100 107-114 129-131 184 218-219 261-263 279 295 312-321 341-346
src/pytom_tm/mask.py 80% 70 85 94-95
src/pytom_tm/matching.py 95% 186-196 340
src/pytom_tm/parallel.py 84% 14-15 81-87 95-97 104 109 148
src/pytom_tm/plotting.py 16% 20-22 25-32 36-44 48-51 54-70 73-74 77-78 98-103 119-127 133-150 165-173 177-194 198-206 210-217 223 229 234 248-398
src/pytom_tm/template.py 57% 57-58 67 76-87 92-97 107-112 114
src/pytom_tm/tmjob.py 96% 177-178 190 196-198 201 334 374
src/pytom_tm/utils.py 78% 16-18
src/pytom_tm/weights.py 96% 61 292-293 300 480 483 486

Minimum allowed coverage is 79%

Generated by 🐒 cobertura-action against 400175d

Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 missing test, 2 leftover imports, 1 style comment (feel free to ignore) and a question about the convention. LGTM otherwise

@McHaillet McHaillet requested a review from sroet April 4, 2024 21:24
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing my comments.

Feel free to merge

@McHaillet McHaillet merged commit 1291893 into SBC-Utrecht:main Apr 5, 2024
2 checks passed
@McHaillet McHaillet deleted the phase_plate_ctf branch April 5, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argparse grouping for readability phase shift in CTF to model vpp phase plate
2 participants