-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase plate ctf and argparse grouping #157
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 400175d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 missing test, 2 leftover imports, 1 style comment (feel free to ignore) and a question about the convention. LGTM otherwise
Co-authored-by: Sander Roet <[email protected]>
Co-authored-by: Sander Roet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing my comments.
Feel free to merge
In this PR I added the following:
For the phase shift parameter I had to make job reading backwards compatible, so I added another version based check.
Closes #150 and closes #76