Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctf model ramp weighting correction and updated interpolation center #141

Merged
merged 18 commits into from
Mar 6, 2024

Conversation

McHaillet
Copy link
Collaborator

@McHaillet McHaillet commented Mar 6, 2024

This PR updates internal code in _create_tilt_weighted_wedge to create a more precise weighting function.

First I add a linear weighting up to the point where tilt image overlap in Fourier space. This now allows summation of the tilts instead of doing a maximum operation. It reduces aliasing artifacts quite a lot:

Before:
ctf_model_before_0 5

After:
ctf_model_after_0 5

The second update (which is also visible in the image, but difficult to see), is that I changed the interpolation center when tilting the images. I switched to voltools instead of ndimage.rotate as this allows me to set the center to the origin in Fourier space, while ndimage.rotate instead uses (shape - 1) / 2, which is not correct for fourier space. In the above image the wedge is shifted one pixel to the left. But this can be quite crucial for the overlap of low frequencies between the tomo and template.

@McHaillet McHaillet requested a review from sroet March 6, 2024 11:27
@McHaillet
Copy link
Collaborator Author

And I updated the version to 0.5.0 to cut a release with this update!

Copy link

github-actions bot commented Mar 6, 2024

File Coverage Missing
All files 80%
src/pytom_tm/angles.py 94% 44
src/pytom_tm/correlation.py 85% 94-95 126
src/pytom_tm/entry_points.py 68% 27 104-121 283-342 431-445 542-557 791-858 899-910
src/pytom_tm/extract.py 73% 107-118 170-176 202-205 277-295
src/pytom_tm/io.py 42% 14-18 24-27 33-36 42-45 51-54 61-65 73-86 92-99 106-113 128-130 163 197-198 243-245 261 277 294-303 323-328
src/pytom_tm/mask.py 80% 70 85 94-95
src/pytom_tm/matching.py 95% 186-196 340
src/pytom_tm/parallel.py 84% 14-15 81-87 95-97 104 109 148
src/pytom_tm/plotting.py 16% 20-22 25-32 36-44 48-51 54-70 73-74 77-78 98-103 119-127 133-150 165-173 177-194 198-206 210-217 223 229 234 248-398
src/pytom_tm/template.py 57% 57-58 67 76-87 92-97 107-112 114
src/pytom_tm/tmjob.py 96% 170-171 183 189-191 194 327 367
src/pytom_tm/utils.py 78% 16-18
src/pytom_tm/weights.py 96% 61 292-293 300 479 482 485

Minimum allowed coverage is 79%

Generated by 🐒 cobertura-action against 36514aa

Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one leftover old code LGTM otherwise

src/pytom_tm/weights.py Outdated Show resolved Hide resolved
@McHaillet McHaillet requested a review from sroet March 6, 2024 11:53
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to merge

@McHaillet McHaillet merged commit 6820bfc into SBC-Utrecht:main Mar 6, 2024
2 checks passed
@McHaillet McHaillet deleted the ctf-weighting-interp-center branch March 6, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants