-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme to point to pip install instead of source #139
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7bb4399 |
updated the readme some more with the help of the github interface
The tests fail with the same issue that #138 tries to fix, so this shouldprobably be merged after that one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installation part is good!
For the cupy errors, some suggested changes and I also think this part,
To solve cupy installation issues, please check the cupy docs. It might be solved by installing a specific build compatible with the installed cuda toolkit.
, could be changed to first trying to install with the conda cuda-toolkit and cupy option. And if that doesnt work looking at the cupy docs.
Co-authored-by: Marten Chaillet <[email protected]>
@McHaillet, one of your suggestions isn't accurate with the current code behavior. I have implemented the others |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Now that the pip install commands are working, we should update our installation instructions as well