-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for missing libraries #127
Conversation
@McHaillet please wait on the review, python import caching is anoying for these tests |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1e94b9e |
@McHaillet it required some wrangling of the way python caches imports, but the tests seem to pass 😄 and lead to an increase of a (couple) percent on the test coverage. Please have a look to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I guess the import matplotlib
line in extract.py can be removed (dont know why I put that there in the first place): https://github.com/sroet/pytom-template-matching-gpu/blob/4418d20aec37942f55785406a7dc893784d3c3d8/src/pytom_tm/extract.py#L20
Co-authored-by: Marten <[email protected]>
Done as well, please have another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This should add coverage for the lines that deal with missing optional modules