Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes for template generation and preparation #114

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

McHaillet
Copy link
Collaborator

Two small changes here because I encountered issues with these things in the dataset I am processing.

Template generation used to do padding with edge mode (left image) and now instead pads with zeros (right). This reduces edge artifacts if the reference structure has a zeroed background (which should be the case for EM maps!).

pytom-template_with_and_without_zero_padding

Second change is that the template is now always multiplied with the mask before starting template matching (instead of after applying the wedge), this significantly reduces artifacts from convolution with the missing wedge. Left image is before, right image is after:

pytom-wedge_with_and_without_prior_masking

@McHaillet McHaillet requested a review from sroet February 21, 2024 13:50
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! feel free to merge

@McHaillet McHaillet merged commit 1280814 into SBC-Utrecht:main Feb 21, 2024
@McHaillet McHaillet deleted the bug-fixes-template branch February 21, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants