-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-datepicker): implement ACC support #763
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
767525a
feat: implement create control script
tsanislavgatev 2f2ba11
fix: create control script pr notes fix
tsanislavgatev f722bb6
add console error on empty string for a name of component
tsanislavgatev 1357c13
solve conflict
tsanislavgatev 849e594
master update
tsanislavgatev bd9bf48
removed hungarian notation
tsanislavgatev 4b82ba5
removed old component creation snippet file
tsanislavgatev f77bfb6
feat(ui5-tabcontainer): acc update
tsanislavgatev 8d26917
merge conflict solve
tsanislavgatev a9235f7
merge conflict tags solve
tsanislavgatev fdd2118
feat(ui5-tabcontainer): update ACC of header and content
tsanislavgatev af2422c
feat(ui5-tabcontainer): update ACC of header and content
tsanislavgatev 23be11a
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 4850ce6
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 3c71085
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 067dbaa
feat:(ui5-datepicker): update ACC of the component and input included
tsanislavgatev 9d4f2db
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 874d752
Updating with comments from PR
tsanislavgatev 6d1dc16
Update with notes from PR
tsanislavgatev 5ed53a2
Improve of get methods for acc in input
tsanislavgatev 70b5104
update with comments from pr
tsanislavgatev d6598da
changing the place of input parent information
tsanislavgatev 0c842f7
update escaping information repeating
tsanislavgatev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
@import "./InvisibleTextStyles.css"; | ||
|
||
:host(:not([hidden])) { | ||
display: inline-block; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when the value of this.isOpen() is changed? Does something invalidate so that the component can be invalidated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the picker gets opened or closed
this. _isPickerOpen
is mutated, which invalidates theui5-datepicker
, andthis.isOpen()
will return eithertrue
, orfalse
when calculated for the HBS template upon rendering. (If that was the question)