Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-select): styles cleanup #670

Merged
merged 3 commits into from
Jul 24, 2019
Merged

refactor(ui5-select): styles cleanup #670

merged 3 commits into from
Jul 24, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Jul 23, 2019

No description provided.

@MapTo0 MapTo0 mentioned this pull request Jul 23, 2019
Closed
@vladitasev vladitasev self-requested a review July 23, 2019 13:08
vladitasev
vladitasev requested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options in the select list are not properly aligned on IE.
The selected option showed in select itself is not properly aligned too (IE), but not as badly as the list options.
The focus is not inside (like with button) but I think it's ok.

vladitasev
vladitasev previously approved these changes Jul 24, 2019
View reviewed changes
@MapTo0 MapTo0 mentioned this pull request Jul 24, 2019
Closed
@MapTo0 MapTo0 merged commit d2210f3 into master Jul 24, 2019
@MapTo0 MapTo0 deleted the select-css-refactoring branch July 24, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev vladitasev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MapTo0 @ilhan007 @vladitasev