refactor: remove press event in favour of click #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also rename two-word events from press to click for consistency BREAKING CHANGE: ui5-button press event is renamed to click BREAKING CHANGE: ui5-card headerPress event is renamed to headerClick BREAKING CHANGE: ui5-link press event is renamed to click BREAKING CHANGE: ui5-list itemPress event is renamed to itemClick BREAKING CHANGE: ui5-shellbar notificationPress event is renamed to notificationClick BREAKING CHANGE: ui5-shellbar profilePress event is renamed to profileClick BREAKING CHANGE: ui5-shellbar productSwitchPress event is renamed to productSwitchClick BREAKING CHANGE: ui5-shellbar logoPress event is renamed to logoClick BREAKING CHANGE: ui5-shellbar coPilotPress event is renamed to coPilotClick BREAKING CHANGE: ui5-shellbar menuItemPress event is renamed to menuItemClick
fifoosid
reviewed
Jun 27, 2019
packages/main/test/sap/ui/webcomponents/main/pages/ShellBar.html
Outdated
Show resolved
Hide resolved
MapTo0
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also rename two-word events from press to click for consistency
BREAKING CHANGE: ui5-button press event is renamed to click
BREAKING CHANGE: ui5-card headerPress event is renamed to headerClick
BREAKING CHANGE: ui5-link press event is renamed to click
BREAKING CHANGE: ui5-list itemPress event is renamed to itemClick
BREAKING CHANGE: ui5-shellbar notificationsPress event is renamed to notificationsClick
BREAKING CHANGE: ui5-shellbar profilePress event is renamed to profileClick
BREAKING CHANGE: ui5-shellbar productSwitchPress event is renamed to productSwitchClick
BREAKING CHANGE: ui5-shellbar logoPress event is renamed to logoClick
BREAKING CHANGE: ui5-shellbar coPilotPress event is renamed to coPilotClick
BREAKING CHANGE: ui5-shellbar menuItemPress event is renamed to menuItemClick
BREAKING CHANGE: ui5-timeline-item itemNamePress event is renamed to itemNameClick