fix(ui5-shellbar): Fix profile bg-color #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
approved these changes
Jul 13, 2020
|
Hi all, I tried to install again @ui5webcomponents, @ui5/webcomponents-react and @ui5/webcomponents-fiori but the color of the avatat components seems to be the same. I'm new to this so what would be the right way to implement this fix? Thanks in advance. |
|
The fix is not yet released. It will be part of RC.8, to be released in 2 weeks. BR, ilhan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to force
background-color: transparentto the ui5-avatar, when used as profile. But, it turns out that this is not needed, in classic UI5, the Avatar is displayed with its default AccentBGColor6 and we align to this with the change.Moreover, in Fiori3 Dark, the transparent Avatar leads to missing color contrast as shown in the issue.
FIXES: #1944