Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-shellbar): enable tooltips of custom icons #1863

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

ilhan007
Copy link
Member

Changes:

  • enable tooltips for custom shellbar items
  • set tooltips for the built-in icons: search, notifications, profile, products and oveflow
  • fix "count" stopped displaying after replacing ui5-icon with ui5-button

FIXES: #1854

Changes:
- enable tooltips for custom shellbar items
- set tooltips for the built-in icons: search, notifications, profile, products and oveflow
- fix count stopped displaying after replacing ui5-icon with ui5-button

FIXES: #1854
@ilhan007 ilhan007 merged commit 4338d56 into master Jun 24, 2020
@ilhan007 ilhan007 deleted the feat-shellbar-items-tooltip branch June 24, 2020 06:32
ilhan007 added a commit that referenced this pull request Jun 24, 2020
Changes:
- enable tooltips for custom shellbar items
- set tooltips for the built-in icons: search, notifications, profile, products and oveflow
- fix count stopped displaying after replacing ui5-icon with ui5-button

FIXES: #1854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Tooltips for ShellBar icons
2 participants