feat(tools): Templates can be imported from node_modules/ #1860
+34
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows
.hbs
template authors to:.hbs
files from anywhere in the local filesystem: path starting with.
or..
.hbs
files fromnode_modules/
Examples:
{{>include "./Popup.hbs"}}
{{>include "../my_partials/Header.hbs"}}
{{>include "@ui5/webcomponents/src/ListItem.hbs"}}
This will enable third party developers to extend our components and implement the partials.
For the purpose, we need to start shipping the
src/
directory ofmain
andfiori
.In addition, some parts of the
hbs2lit
andhbs2ui5
libs have been improved, most notablyincludesReplacer
in order to be able to recursively parse include statements while simultaneously keeping track of the current relative path of the currently parsed file so that relative references inside it can work properly.closes: #1859