fix(ui5-input): fix JS errors when open/close popups #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are use cases when the user dynamically appends/removes the value state msg slot and we have to check if the value state msg popover is present before opening or closing it. FIXES: #1790
vladitasev
approved these changes
Jun 16, 2020
ilhan007
added a commit
that referenced
this pull request
Jun 16, 2020
There are use cases when the user dynamically appends/removes the value state msg slot and we have to check if the value state msg popover is present before opening or closing it. FIXES: #1790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases when the user dynamically appends/removes the value state msg slot
and we have to check if the value state msg popover is present before opening or closing it.
(The change in the test page has nothing to do with the fix, it is just visually improved.)
FIXES: #1790