Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-shellbar): fix search field visual in IE #1643

Merged
merged 2 commits into from
May 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/fiori/src/themes/ShellBar.css
Original file line number Diff line number Diff line change
Expand Up @@ -373,14 +373,28 @@ ui5-icon[data-count]::before {
height: 100%;
}

::slotted(ui5-input:hover) {
::slotted(ui5-input[focused]) {
outline: 1px dotted var(--sapContent_ContrastFocusColor);
}

/**
* IE styles
*/
ui5-input[value-state]:not([readonly]) {
background: var(--sapShellColor);
border: 1px solid var(--sapShell_InteractiveBorderColor);
}

ui5-input[value-state]:not([readonly]):hover,
ui5-input:not([value-state]):not([readonly]):hover {
background: var(--sapShell_Hover_Background);
border: 1px solid var(--sapShell_InteractiveBorderColor);
}

::slotted(ui5-input[focused]) {
ui5-input[value-state]:not([value-stat="None"])[focused] {
outline: 1px dotted var(--sapContent_ContrastFocusColor);
}

/* IE styles end */

.ui5-shellbar-copilot-wrapper {
position: relative;
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/test/pages/ShellBar.html
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<ui5-shellbar-item icon="action-settings" text="Settings"></ui5-shellbar-item>
<ui5-shellbar-item icon="sys-help" text="Help"></ui5-shellbar-item>

<ui5-input slot="searchField"></ui5-input>
<ui5-input slot="searchField" value-state="Error"></ui5-input>

</ui5-shellbar>

Expand Down