Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-select): implement accessibility spec #1485

Merged
merged 6 commits into from
Apr 22, 2020
Merged

feat(ui5-select): implement accessibility spec #1485

merged 6 commits into from
Apr 22, 2020

Conversation

nnaydenow
Copy link
Contributor

vladitasev
vladitasev requested changes Apr 16, 2020
View reviewed changes
packages/main/src/Select.js Outdated Show resolved Hide resolved
packages/main/src/Select.hbs Outdated Show resolved Hide resolved
elenastoyanovaa
elenastoyanovaa requested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the disabled to aria-disabled. Everything else is read out correctly. Good job :)

packages/main/src/Select.hbs Outdated
aria-haspopup="listbox"
aria-labelledby="{{_id}}-label"
aria-describedby="{{valueStateTextId}}"
?disabled="{{disabled}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is an ordinary div, not an input , this should be aria-disabled, not just disabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

elenastoyanovaa
elenastoyanovaa reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ACC side

@vladitasev vladitasev merged commit ede3635 into SAP:master Apr 22, 2020
@nnaydenow nnaydenow deleted the select branch August 10, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev vladitasev approved these changes

@elenastoyanovaa elenastoyanovaa elenastoyanovaa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnaydenow @elenastoyanovaa @ilhan007 @vladitasev