fix(framework): Provide a workaround for Firefox 74 shadow root bug #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested review from
d3xter666,
MapTo0,
pskelin,
elenastoyanovaa,
ilhan007 and
fifoosid
ilhan007
approved these changes
Mar 25, 2020
fifoosid
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox 74 seems to have a bug regarding shadow root creation. Even though
attachShadowis called in the constructor,this.shadowRootis stillnullinconnectedCallback. If you try to create it again there, it fails, as it was already created, it's just not available yet. Therefore withmanagedSlots: trueit works, as there is async work going on, and theshadowRootis ready when rendering.The fix is to await a microtask, if there is no shadow root in
connectedCallbackandneedsShadowRootis equal totrue.