Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-dialog): dialog focus trapping works again #1213

Merged
merged 2 commits into from
Feb 12, 2020
Merged

fix(ui5-dialog): dialog focus trapping works again #1213

merged 2 commits into from
Feb 12, 2020

Conversation

vladitasev
Copy link
Contributor

An "onfocusin" event was left over in Popup.js (not bound from the template, and having the name of the original event)

@vladitasev vladitasev mentioned this pull request Feb 12, 2020
Closed
@vladitasev vladitasev merged commit e899708 into master Feb 12, 2020
@vladitasev vladitasev deleted the fix-dialog-focus-trapping branch February 12, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

@pskelin pskelin Awaiting requested review from pskelin

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladitasev @fifoosid